Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add partition field for catalog deregister docs #21788

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Add partition field for catalog deregister docs #21788

merged 2 commits into from
Sep 27, 2024

Conversation

jm96441n
Copy link
Member

Description

We accept a Partition field for deregistering nodes and it is required if you're trying to deregister a node that only exists in a particular partition.

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@jm96441n jm96441n added type/docs Documentation needs to be created/updated/clarified pr/no-changelog PR does not need a corresponding .changelog entry backport/all Apply backports for all active releases per .release/versions.hcl labels Sep 27, 2024
@jm96441n jm96441n requested a review from a team as a code owner September 27, 2024 16:51
boruszak
boruszak approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion to incorporate, otherwise LGTM!

website/content/api-docs/catalog.mdx Outdated Show resolved Hide resolved
@jm96441n @boruszak
Update website/content/api-docs/catalog.mdx
64cf21e 
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
@jm96441n jm96441n enabled auto-merge (squash) September 27, 2024 17:12
@jm96441n jm96441n merged commit a689893 into main Sep 27, 2024
63 of 64 checks passed
@jm96441n jm96441n deleted the update-catalog-docs-for-partition-field branch September 27, 2024 17:16
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.19 Changes are backported to 1.19 backport/1.20 Changes are backported to 1.20 backport/ent/1.17 Changes are backported to 1.17 ent backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent labels Sep 27, 2024
This was referenced Sep 27, 2024
Open
Open
@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @jm96441n! a backport is missing for this PR [21788] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

8 similar comments
@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @jm96441n! a backport is missing for this PR [21788] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @jm96441n! a backport is missing for this PR [21788] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @jm96441n! a backport is missing for this PR [21788] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @jm96441n! a backport is missing for this PR [21788] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @jm96441n! a backport is missing for this PR [21788] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @jm96441n! a backport is missing for this PR [21788] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @jm96441n! a backport is missing for this PR [21788] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @jm96441n! a backport is missing for this PR [21788] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boruszak boruszak boruszak approved these changes

Assignees
No one assigned
Labels
backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.17 Changes are backported to 1.17 ent backport/ent/1.18 Changes are backported to 1.18 ent backport/1.19 Changes are backported to 1.19 backport/1.20 Changes are backported to 1.20 pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jm96441n @hc-github-team-consul-core @boruszak